Majority Games Disclosed Report

Description

When a creator sponsors an amount to the game, it is added to totalCollectedAmount. At the end of the game, the winner’s reward is calculated as:

reward = totalCollectedAmount - (creatorFee + protocolFee + REFERRER_FEE)

The issue arises because the referrer fee is always subtracted from the totalCollectedAmount, even though the sponser amount has no referrer. As a result, a percentage of the sponsored amount corresponding to the referrer fee is deducted but not credited to anyone.

Impact

• The deducted referrer fee portion of the sponsored amount remains stuck in the contract.

• Neither the winner, the creator, nor the protocol can claim this value.

• This effectively reduces the winner’s reward unfairly and leads to locked end user funds in the contract.

Expected Behavior

Modify the reward calculation to conditionally subtract the REFERRER_FEE only when a valid referrer exists. Create a seperate variable to track the referrer fees.

1. Deploy the game contract and fee distribution logic.

2. Have a creator sponsor a game with a non-zero amount, adding it to totalCollectedAmount.

3. Start the game and have players join by paying ticket fees.

4. Conclude the game and determine the winner.

5. The winner calls the reward distribution function.

6. we can Observe that the referrer fee portion of the sponsored amount is deducted but not assigned to anyone, remaining stuck in the contract.